DB migration scripts fixed for PostgreSQL, MSSQL and DB2 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
bogdan-bondar
approved these changes
Dec 15, 2020
schabdo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the database migration scripts version 1_12_16 for PostgreSQL, Microsoft SQL Server and DB2.
The script for DB2 does not work, the scripts for PostgreSQL and Microsoft SQL Server only work if the sp_action table is empty. The reason is that a column was added that does not allow a null value, which results in an error.
To fix that a default value was added to the column. The default value is an empty string and the default is removed from the column after is is created. That way we get the same behaviour that we have when using MySQL.